Fix ASan heap-buffer-overflow in signal handlers #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protect methods called from signal handlers against partially initialized thread structures during GC worker thread creation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Scan-Build Report
Bug Summary
Reports
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Scan-Build Report
Bug Summary
Reports
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Scan-Build Report
Bug Summary
Reports
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rkennke
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Use SafeAccess for signal-handler memory reads in vmStructs.h to prevent crashes when reading from partially initialized thread structures during GC worker thread creation.
Motivation:
Fixes ASan heap-buffer-overflow errors in CI where the CTimer signal handler was delivering signals to newly created GC worker threads before their
VMThreadstructure was fully initialized. The TLS pointer returned a valid address but offset calculations resulted in reading memory before the allocated region ("72 bytes to the left").Additional Notes:
While doing this change I took a sweep on other signal-handler-accessible methods where
SafeAccessmakes sense:VMThread::state()- UsesSafeAccess::load32()VMThread::inDeopt()- UsesSafeAccess::loadPtr()JavaFrameAnchor::lastJavaSP()- UsesSafeAccess::loadPtr()JavaFrameAnchor::lastJavaFP()- UsesSafeAccess::loadPtr()JavaFrameAnchor::lastJavaPC()- UsesSafeAccess::loadPtr()JavaFrameAnchor::fromEntryFrame()- UsesSafeAccess::loadPtr()How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.🤖 Generated with Claude Code